fix: column selection + latest Docker tag#34
Merged
Conversation
Smart Generation UI improvements: - Map, nested (ARRAY JOIN), and AI fields default to unchecked (opt-in) - Count measure and required fields (rewrite rules + filters) always selected - "Start Over" button on change preview step resets to table selection - "Skip LLM enrichment" checkbox on column selection step - AI metrics section starts unchecked (opt-in, not opt-out) - AI metrics empty selection sends empty array to prevent backend include-all bug - Source tag support in ChangeField interface (map, nested, ai) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The frontend checkbox existed but the GraphQL variable was never declared in the mutation, so URQL silently dropped it. Now wired end-to-end. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
setSelectedModelFields was called on preview result and start-over but never declared via useState, causing a ReferenceError that crashed the smart gen UI and prevented models from being created. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… generated document excludedFields was referenced but never declared, causing ReferenceError that crashed the apply step — no models could be created. Also add skip_llm variable declaration to the generated GraphQL document so URQL actually sends it to Hasura (codegen couldn't run due to schema mismatches, so the document was manually updated). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The infra dev overlay now uses `latest` tags for all synmetrix images. Client-v2 was only pushing the SHA tag — ArgoCD couldn't pick up new builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
selectedColumns was initialized to only columns with data (has_values && value_rows > 0). For empty tables/partitions, this meant zero columns selected, so selected_columns was never sent and the backend built models with all columns regardless of the user's checkbox selections. Now all columns start checked — the user's deselections are the source of truth. The isSubset check compares against total column count, not active-data column count. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
acmeguy
changed the title
- Map and nested fields now included by default in change preview (previously opt-in with no UI to select them — dead on arrival) - Only AI-generated fields remain opt-in (has separate selection UI) - Initialize selectedColumns from all columns, not just active ones - Add excluded_fields to GraphQL document - Compare column subset against total count, not active-data count Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yasirali179
approved these changes
Apr 18, 2026
…in-ui # Conflicts: # src/components/SmartGeneration/index.tsx # src/graphql/generated.ts # src/graphql/gql/datasources.gql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latestDocker tag on master builds so ArgoCD dev overlay auto-deploys.Test plan
latesttags🤖 Generated with Claude Code