fix: excludedFields crash + skip_llm in GraphQL document#33
Merged
Conversation
Smart Generation UI improvements: - Map, nested (ARRAY JOIN), and AI fields default to unchecked (opt-in) - Count measure and required fields (rewrite rules + filters) always selected - "Start Over" button on change preview step resets to table selection - "Skip LLM enrichment" checkbox on column selection step - AI metrics section starts unchecked (opt-in, not opt-out) - AI metrics empty selection sends empty array to prevent backend include-all bug - Source tag support in ChangeField interface (map, nested, ai) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The frontend checkbox existed but the GraphQL variable was never declared in the mutation, so URQL silently dropped it. Now wired end-to-end. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
setSelectedModelFields was called on preview result and start-over but never declared via useState, causing a ReferenceError that crashed the smart gen UI and prevented models from being created. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… generated document excludedFields was referenced but never declared, causing ReferenceError that crashed the apply step — no models could be created. Also add skip_llm variable declaration to the generated GraphQL document so URQL actually sends it to Hasura (codegen couldn't run due to schema mismatches, so the document was manually updated). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Valdegg
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludedFieldsfromselectedModelFieldsandchangePreview— was referenced but never declared, causingReferenceErrorthat crashed the apply stepskip_llmvariable to the generated GraphQL document ingenerated.ts— URQL was silently dropping it because the document didn't declare the variableRoot cause
Two undeclared variables in SmartGeneration component:
excludedFields— used on apply but never computed from stateskip_llmin generated.ts — codegen couldn't run (schema mismatches with other .gql files), so the document was staleTested
Test plan
🤖 Generated with Claude Code