chore(ci): align workflow frontend-copy with Makefile frontend-build#474
Merged
Merged
Conversation
PR #473 changed the Makefile `frontend-build` target to copy into `web/frontend/dist/` and `touch web/frontend/dist/.gitkeep` (so the `//go:embed all:frontend/dist` directive always has something to embed). The release.yml and pr-build.yml "Copy frontend dist" steps still used the older `cp -r frontend/dist web/frontend/` form. Both forms place a real index.html under web/frontend/dist/ so release artifacts were never broken, but the divergent forms are confusing and the workflow steps did not recreate the tracked .gitkeep. This aligns both workflows with the Makefile so there is a single canonical form. Follow-up to #473. No functional change to release/CI artifacts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
59457b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bcf31fa7.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://chore-align-workflow-fronten.mcpproxy-docs.pages.dev |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 25983030215 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #473. That PR changed the Makefile
frontend-buildtarget to:but left the
Copy frontend diststeps inrelease.ymlandpr-build.ymlon the older form:Both forms place a real
index.htmlunderweb/frontend/dist/, so release artifacts (Homebrew, Docker, .deb, DMG, etc.) were never broken — the divergence was purely a maintenance/consistency hazard, and the workflows did not recreate the tracked.gitkeep. This change makes the two CI workflows use the exact same canonical form as the Makefile.Changes
.github/workflows/release.yml— copy step nowcp -r frontend/dist/. web/frontend/dist/+touch web/frontend/dist/.gitkeep.github/workflows/pr-build.yml— sameRisk
None functional. The embed input is identical (real Vite bundle under
web/frontend/dist/); only the copy form and an extra harmless.gitkeeptouch change. YAML validated.Merge order
Best merged after #473 (the
.gitkeepis meaningless until #473 tracks it), but functionally safe in either order sinceweb/frontend/is gitignored onmaintoday.🤖 Generated with Claude Code