Fixes explore click tool bug with categorical variables#79
Open
rfballantyne wants to merge 7 commits into
Open
Fixes explore click tool bug with categorical variables#79rfballantyne wants to merge 7 commits into
rfballantyne wants to merge 7 commits into
Conversation
added 7 commits
December 5, 2024 11:22
… that it's working as intended, then need to add functionality for potential species.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the click tool so it can identify culverts for categorical variables.
I recommend viewing the code files for this PR with whitespace changes turned off.
Note: this solution does rely on hard-coding which column index each variable is assigned to in the histogram. If we add a fish species or get data points for owner types not currently represented in the data (for example: Port), we would need to update these lines.
You can find videos displaying the functionality for each categorical variable here.
How to turn off whitespace only changes when reviewing the code:
