Skip to content

🎨 Palette: Add async loading states to authentication forms#170

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette/form-loading-states-8222680433597006948
Open

🎨 Palette: Add async loading states to authentication forms#170
singhaditya21 wants to merge 1 commit into
mainfrom
palette/form-loading-states-8222680433597006948

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Added visual loading spinners (aria-busy="true", disabled="true") to the Login and Registration form submit buttons while waiting for the mock API response.
🎯 Why: Without visual feedback during asynchronous API calls, users might think the application is frozen or unresponsive, leading them to click the submit button multiple times or abandon the task.
📸 Before/After: Visual changes verified via Playwright screenshot; the button displays an hourglass and "Logging in..." / "Signing up..." text during request.
♿ Accessibility: The loading state includes an aria-busy="true" attribute to notify screen readers of the pending state, the visual emoji is hidden from screen readers via aria-hidden="true", and the button is disabled to prevent duplicate submissions via both pointer and keyboard actions. The state updates are safely wrapped in a finally block to ensure they reset if an error occurs.


PR created automatically by Jules for task 8222680433597006948 started by @singhaditya21

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant