Skip to content

🎨 Palette: Add loading states to authentication buttons#169

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette-async-loading-states-10155714658533912287
Open

🎨 Palette: Add loading states to authentication buttons#169
singhaditya21 wants to merge 1 commit into
mainfrom
palette-async-loading-states-10155714658533912287

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

What: Added visual loading states (changing text to "Loading..." and disabling the button) to all authentication forms (Login, Register, and Google Sign-In) during asynchronous API calls. Also added a new palette.md journal entry.

Why: To provide immediate visual feedback to users that their request is being processed. This prevents multiple clicks on the submit buttons and improves perceived performance and system status visibility.

Before/After:

  • Before: Clicking "Sign In with Email", "Sign Up", or "Continue with Google" provided no visual feedback on the button itself while the network request was in flight.
  • After: The clicked button immediately disables and changes its text to "Loading...", then gracefully restores its original state regardless of API success or failure using try/finally blocks.

Accessibility:

  • Disabling the button during the request prevents duplicate submissions and conveys a busy state to screen readers.
  • The use of try/finally ensures that buttons don't remain stuck in a disabled state if an error occurs, maintaining navigability.

PR created automatically by Jules for task 10155714658533912287 started by @singhaditya21

Added visual loading states to the login, register, and Google sign-in buttons to provide immediate feedback during async operations. Used try/finally blocks to ensure UI states recover gracefully. Also added a journal entry documenting the learning around vanilla JS form submission handling.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant