Skip to content

🎨 Palette: Add async loading states to auth buttons#166

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette-async-loading-states-17990622401849054927
Open

🎨 Palette: Add async loading states to auth buttons#166
singhaditya21 wants to merge 1 commit into
mainfrom
palette-async-loading-states-17990622401849054927

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Added async loading states (showing a spinner/text and disabling the button) to all authentication actions (Login, Register, and Google Sign-in).
🎯 Why: 'Submit' events don't inherently block interactions. Adding a loading state and disabling the button immediately improves perceived performance, provides visual feedback, and prevents duplicate submissions.
📸 Before/After: Before, the buttons stayed exactly the same when clicked. Now they disable themselves and say "⏳ Logging in...", "⏳ Connecting...", etc.
Accessibility: Added :focus-visible for keyboard navigation, and the buttons receive aria-busy="true" dynamically when loading.


PR created automatically by Jules for task 17990622401849054927 started by @singhaditya21

This commit implements async loading states and disables multiple submissions for the authentication buttons (Login, Register, Google Sign-In) to enhance user experience and accessibility.
A try/finally block was introduced in `app.js` to ensure the button's visual and functional state recovers correctly. Furthermore, `:disabled` and `:focus-visible` pseudo-classes were added to `.btn` in `style.css`.
A journal entry regarding this finding was added to `.Jules/palette.md`.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant