Skip to content

🎨 Palette: [Add loading state to login button]#163

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette/login-loading-state-12545997534676137489
Open

🎨 Palette: [Add loading state to login button]#163
singhaditya21 wants to merge 1 commit into
mainfrom
palette/login-loading-state-12545997534676137489

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Added a visual and semantic loading state to the Login button during asynchronous API requests.
🎯 Why: Previously, users received no visual feedback when clicking "Sign In", potentially leading to double-submissions and a confusing experience on slower networks.
📸 Before/After: N/A - See code for logic changes.
♿ Accessibility: Set aria-busy='true' and disabled=true while the request is in-flight to prevent duplicate actions and correctly inform screen readers of the pending state.


PR created automatically by Jules for task 12545997534676137489 started by @singhaditya21

Added disabled state, `aria-busy` attribute, and visual text change during async login submissions.
Ensured original state is robustly restored using a try...finally block.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant