🎨 Palette: Add async loading states to authentication buttons#161
🎨 Palette: Add async loading states to authentication buttons#161singhaditya21 wants to merge 1 commit into
Conversation
- Use `e.submitter` to target form submission buttons accurately. - Introduce robust state reset inside `finally` blocks for `handleLogin`, `handleRegister`, and `handleGoogleSignIn`. - Await a Promise-wrapped timeout in `handleGoogleSignIn` to allow loading states to persist during mocked delays. - Add `aria-busy` attribute during loading states for better accessibility. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added async loading states (spinner + updated text) to the Login, Register, and Google Sign-in buttons.
🎯 Why: Users previously had no visual feedback that an authentication request was in progress, leading to potential duplicate clicks or confusion during network delays.
📸 Before/After: Before, buttons remained static when clicked. After, they disable, show a spinner, and update their text (e.g., "⏳ Logging in...") before strictly resetting.
♿ Accessibility: Added
aria-busy="true"to buttons during their loading state to inform assistive technologies.PR created automatically by Jules for task 17905411354166784560 started by @singhaditya21