Skip to content

🎨 Palette: Add async loading states for auth forms#159

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette-add-async-loading-states-11626954485311952742
Open

🎨 Palette: Add async loading states for auth forms#159
singhaditya21 wants to merge 1 commit into
mainfrom
palette-add-async-loading-states-11626954485311952742

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Added loading states to the Login, Register, and Google Sign In buttons. When clicked, the button text changes to '⏳ Loading...', it becomes disabled, and an aria-busy="true" attribute is added. The state is guaranteed to be restored using try/finally blocks.
🎯 Why: To provide immediate visual feedback during simulated asynchronous API calls and prevent users from double-submitting authentication forms.
📸 Before/After: Before, the buttons had no visual feedback or disabled state during submission. After, they provide clear feedback and lock interaction until the process completes.
Accessibility: Added aria-busy="true" to communicate the loading state to assistive technologies, and disabled="true" to ensure keyboard users cannot trigger multiple submissions.


PR created automatically by Jules for task 11626954485311952742 started by @singhaditya21

Adds loading states with try/finally blocks for Login, Register, and Google Sign In forms to disable the buttons, prevent double submission, update text, and indicate loading for screen readers via aria-busy.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant