🎨 Palette: Add loading states to authentication buttons#157
🎨 Palette: Add loading states to authentication buttons#157singhaditya21 wants to merge 1 commit into
Conversation
Add proper loading states to the Login, Register, and Google Sign-In buttons in the vanilla JavaScript frontend. Changes: - Added `aria-busy="true"` and `disabled` attributes during async operations. - Updated button text to "Logging in...", "Connecting...", etc. - Leveraged `e.submitter` to reliably target the triggering button. - Refactored setTimeout in handleGoogleSignIn to an awaitable Promise. - Implemented `finally` blocks to guarantee state restoration. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Added loading states (disabled,
aria-busy, and text changes) to the Login, Register, and Google Sign-In buttons in the vanilla JS app.🎯 Why
Previously, the buttons had no visual feedback upon clicking, allowing double submissions and causing confusion if the API took time to respond. Providing immediate visual feedback improves user trust and interface intuitiveness.
📸 Before/After
Before: Clicking "Sign In" does not change the button, it remains clickable.
After: Clicking "Sign In" changes the text to "Logging in...", grays out the button (disabled), and prevents additional clicks until the process resolves (or fails).
♿ Accessibility
Added
aria-busy="true"to the buttons during the asynchronous requests, explicitly informing screen readers that the section is currently processing information. Added robustfinallyblocks to ensure accessibility states are cleaned up even if the operation throws an error.PR created automatically by Jules for task 13038865507556520644 started by @singhaditya21