Skip to content

🎨 Palette: Add loading states to auth buttons#156

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette-auth-loading-17051716715496174956
Open

🎨 Palette: Add loading states to auth buttons#156
singhaditya21 wants to merge 1 commit into
mainfrom
palette-auth-loading-17051716715496174956

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Added disabled and text-loading states to the Login and Register buttons during their respective asynchronous operations, utilizing a safe try/finally block and e.submitter.
🎯 Why: To prevent double submissions from impatient users and provide clear, immediate visual feedback that the application is processing their request.
📸 Before/After: Before, the button remained clickable and visually static during the simulated network delay. After, it immediately disables and changes text to "Signing In..." or "Signing Up...", providing proper feedback.
Accessibility: Added the aria-busy="true" attribute to the button during the loading state, allowing screen readers to accurately interpret the button's processing status, and then correctly removing it when complete.


PR created automatically by Jules for task 17051716715496174956 started by @singhaditya21

Added loading states to the Login and Register buttons in app.js.
When submitted, the buttons now disable, show a "Signing In/Up..."
message, and get an aria-busy attribute. The states are safely
restored in a finally block.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant