Skip to content

🎨 Palette: Async Form Button Loading States#151

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette/async-button-loading-states-14848538476726881230
Open

🎨 Palette: Async Form Button Loading States#151
singhaditya21 wants to merge 1 commit into
mainfrom
palette/async-button-loading-states-14848538476726881230

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner
  • Added explicitly accessible and visual loading states to handleLogin, handleRegister, and handleGoogleSignIn buttons in web-demo/js/app.js.
  • Converted setTimeout to awaitable Promise inside handleGoogleSignIn to allow proper tracking with a try/finally block.
  • Updated palette.md journal with learning about try/finally blocks and button state restorations.
  • All loading states verify by setting disabled, adding aria-busy=true and replacing content to indicate progress.

PR created automatically by Jules for task 14848538476726881230 started by @singhaditya21

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant