🎨 Palette: Add async loading states to authentication buttons#150
🎨 Palette: Add async loading states to authentication buttons#150singhaditya21 wants to merge 1 commit into
Conversation
- Track `e.submitter` to correctly identify the submitted button. - Set `disabled` and `aria-busy` to `true` while the async request runs. - Change the button's `innerHTML` to display a loading message. - Cache the original `innerHTML` and restore it inside a `finally` block to ensure UI recovery. - Update `handleGoogleSignIn` to use an awaitable `Promise` rather than a standard callback `setTimeout` so the `finally` block successfully waits. - Update `.Jules/palette.md` with relevant vanilla JS learning. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added accessible loading states (
disabled,aria-busy, and visual feedback) to the Email Sign In, Sign Up, and Google Sign In buttons. These states correctly delay user interaction and provide necessary feedback during asynchronous API requests, wrapped in robusttry/finallyblocks to handle clean up in both success and error scenarios.PR created automatically by Jules for task 5933125560700579026 started by @singhaditya21