Skip to content

🎨 Palette: Add async loading states to authentication buttons#147

Open
singhaditya21 wants to merge 1 commit into
mainfrom
palette/async-button-loading-states-7945275892173596306
Open

🎨 Palette: Add async loading states to authentication buttons#147
singhaditya21 wants to merge 1 commit into
mainfrom
palette/async-button-loading-states-7945275892173596306

Conversation

@singhaditya21

Copy link
Copy Markdown
Owner

💡 What: Implemented async loading state indicators for all authentication buttons (handleLogin, handleRegister, and handleGoogleSignIn). When clicked, the buttons become disabled, display "Signing in..." (or "Signing up..."), and set aria-busy="true".
🎯 Why: Provides immediate feedback to users during network requests, preventing duplicate submissions and improving overall perceived performance.
♿ Accessibility: The addition of aria-busy="true" explicitly announces the loading state to screen readers, and the disabled property restricts keyboard activation during requests.


PR created automatically by Jules for task 7945275892173596306 started by @singhaditya21

Added visual and accessible loading states (disabled, aria-busy, and updated text) to the login, register, and Google sign-in buttons while authentication requests are processed, improving user feedback. Ensure states are consistently cleaned up in finally blocks.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant