Skip to content

fix(tracespans): update tracespans tool calls to accurately display inputs for successive identical tool calls #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Feb 5, 2026
Merged

fix(tracespans): update tracespans tool calls to accurately display inputs for successive identical tool calls #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions apps/sim/lib/logs/execution/snapshot/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
import { beforeEach, describe, expect, test } from 'vitest'
import { describe, expect, it } from 'vitest'
import { SnapshotService } from '@/lib/logs/execution/snapshot/service'
import type { WorkflowState } from '@/lib/logs/types'

describe('SnapshotService', () => {
let service: SnapshotService

beforeEach(() => {
service = new SnapshotService()
})

describe('computeStateHash', () => {
test('should generate consistent hashes for identical states', () => {
it.concurrent('should generate consistent hashes for identical states', () => {
const service = new SnapshotService()
const state: WorkflowState = {
blocks: {
block1: {
Expand Down Expand Up @@ -39,7 +34,8 @@ describe('SnapshotService', () => {
expect(hash1).toHaveLength(64) // SHA-256 hex string
})

test('should ignore position changes', () => {
it.concurrent('should ignore position changes', () => {
const service = new SnapshotService()
const baseState: WorkflowState = {
blocks: {
block1: {
Expand Down Expand Up @@ -77,7 +73,8 @@ describe('SnapshotService', () => {
expect(hash1).toBe(hash2)
})

test('should detect meaningful changes', () => {
it.concurrent('should detect meaningful changes', () => {
const service = new SnapshotService()
const baseState: WorkflowState = {
blocks: {
block1: {
Expand Down Expand Up @@ -128,7 +125,8 @@ describe('SnapshotService', () => {
expect(hash1).not.toBe(hash2)
})

test('should handle edge order consistently', () => {
it.concurrent('should handle edge order consistently', () => {
const service = new SnapshotService()
const state1: WorkflowState = {
blocks: {},
edges: [
Expand All @@ -155,7 +153,8 @@ describe('SnapshotService', () => {
expect(hash1).toBe(hash2) // Should be same despite different order
})

test('should handle empty states', () => {
it.concurrent('should handle empty states', () => {
const service = new SnapshotService()
const emptyState: WorkflowState = {
blocks: {},
edges: [],
Expand All @@ -167,7 +166,8 @@ describe('SnapshotService', () => {
expect(hash).toHaveLength(64)
})

test('should handle complex nested structures', () => {
it.concurrent('should handle complex nested structures', () => {
const service = new SnapshotService()
const complexState: WorkflowState = {
blocks: {
block1: {
Expand Down Expand Up @@ -224,7 +224,8 @@ describe('SnapshotService', () => {
expect(hash).toBe(hash2)
})

test('should include variables in hash computation', () => {
it.concurrent('should include variables in hash computation', () => {
const service = new SnapshotService()
const stateWithVariables: WorkflowState = {
blocks: {},
edges: [],
Expand Down Expand Up @@ -253,7 +254,8 @@ describe('SnapshotService', () => {
expect(hashWith).not.toBe(hashWithout)
})

test('should detect changes in variable values', () => {
it.concurrent('should detect changes in variable values', () => {
const service = new SnapshotService()
const state1: WorkflowState = {
blocks: {},
edges: [],
Expand Down Expand Up @@ -290,7 +292,8 @@ describe('SnapshotService', () => {
expect(hash1).not.toBe(hash2)
})

test('should generate consistent hashes for states with variables', () => {
it.concurrent('should generate consistent hashes for states with variables', () => {
const service = new SnapshotService()
const stateWithVariables: WorkflowState = {
blocks: {
block1: {
Expand Down
Loading