-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(action-bar): run button label and hover #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
- Changed 'Run from block' to 'Run' in tooltip - Updated disabled state hover to show 'Disabled: Run Blocks Before' Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryUpdated the "Run from block" button label in the action bar to simply "Run" and improved the disabled state tooltip to "Disabled: Run Blocks Before" for better clarity. The changes maintain consistent messaging between the action bar and context menu logic. Issue Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ActionBar
participant Tooltip
participant WorkflowStore
participant ExecutionStore
User->>ActionBar: Hover over Run button
ActionBar->>WorkflowStore: Check block state (isEnabled, locked, etc)
ActionBar->>ExecutionStore: Check execution state (isExecuting)
ActionBar->>ActionBar: Calculate dependenciesSatisfied
alt Button disabled (permissions)
ActionBar->>Tooltip: Show "Run" with getTooltipMessage()
Tooltip-->>User: Display "Read-only mode" or "Connection lost"
else Execution in progress
ActionBar->>Tooltip: Show "Execution in progress"
Tooltip-->>User: Display message
else Dependencies not satisfied
ActionBar->>Tooltip: Show "Disabled: Run Blocks Before"
Tooltip-->>User: Display message
else Can run
ActionBar->>Tooltip: Show "Run"
Tooltip-->>User: Display message
end
User->>ActionBar: Click Run button (if enabled)
ActionBar->>WorkflowStore: handleRunFromBlock(blockId)
WorkflowStore->>ExecutionStore: Execute workflow from block
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/action-bar/action-bar.tsx
Show resolved
Hide resolved
|
@cursor review |
Summary
Updates the "Run from block" button in the action bar to simply "Run". When the button is disabled due to unsatisfied dependencies, the hover tooltip now displays "Disabled: Run Blocks Before" for improved clarity.
Fixes #(issue) - If an issue exists, add it here.
Type of Change
Testing
The changes were verified by running lint and type checks. Visual inspection of the action bar button and its hover states (enabled and disabled) is recommended.
Checklist
Screenshots/Videos