Tolerate unescaped control characters in AI JSON output#3
Open
kevinmatspie wants to merge 1 commit into
Open
Conversation
json.loads(strict=False) allows literal newlines and tabs inside string values, a common LLM failure mode when emitting multi-line `issue` or `fix` fields without escaping. Previously a stray newline would discard the entire (paid-for) review with no way to recover the AI output. On final parse failure, dump the full AI output to /tmp/reviewd-failed-<timestamp>.txt so the review can be salvaged manually rather than losing all but the first 1000 chars to the error log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json.loads(strict=False) allows literal newlines and tabs inside string values, a common LLM failure mode when emitting multi-line
issueorfixfields without escaping. Previously a stray newline would discard the entire (paid-for) review with no way to recover the AI output.On final parse failure, dump the full AI output to /tmp/reviewd-failed-.txt so the review can be salvaged manually rather than losing all but the first 1000 chars to the error log.