feat(capture): pre-flight microphone permission gate (silent-capture L0)#336
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…t recordings
Catches a denied/unconfirmed microphone permission at record-start instead of
discovering it after a meeting is lost (bead minutes-9bc8; the 8-min silent Zoom
call after a re-signed dev app dropped its mic TCC grant).
- Typed CapturePreflightBlockKind { CallRoute, Permission }; the native-call
bypass (commands.rs + palette_dispatch.rs, via a shared core helper) now skips
only CallRoute blocks, so a Permission block can never be swallowed on the
native-call path.
- Call with recoverable system audio + denied mic warns (salvages the remote
side) rather than blocking; mic-only meeting/memo/dictation/live blocks.
- NotDetermined / StaleOrRestartNeeded warn but never block (the OS prompt still
needs to fire). Pure, OS-free decision functions; capability check, never an
interactive prompt.
- Mic-only pre-flight wired into dictation and live transcript starts too.
- Cross-platform safe: non-macOS reports NotNeeded (no-op).
silverstein
force-pushed
the
feat/preflight-mic-permission-gate
branch
from
2311099 to
99bcf26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the core of bead minutes-9bc8 (silent-capture warning). Catches a denied or unconfirmed microphone permission at record-start, instead of discovering it after a meeting is already lost. Motivated by the real incident where a re-signed dev app dropped its mic TCC grant and an 8-minute Zoom call recorded near-silence with no warning.
This is L0 of a layered capture-integrity model (the deterministic permission check). L1 callback-liveness and L2 statistical dead-stem detection are separate follow-ups.
What it does
CapturePreflightBlockKind { CallRoute, Permission }. The native-call and palette bypass (which intentionally skips the no-system-audio-route block when native capture is available) now skips ONLY CallRoute blocks, via a shared core helper, so a Permission block can never be swallowed on the native-call path. That was the path the incident came from.Deferred follow-ups (not in this PR)
Tests
792 core tests green (5 new), clippy clean on both feature sets, app and cli build. New tests cover recoverable-call warn vs mic-only block, block-kind tagging, the mic-only helper, and a regression test that a Permission block survives the native-call bypass.