feat: add MLX Audio batch transcription backend#325
Conversation
|
Someone is attempting to deploy a commit to the evil genius laboratory Team on Vercel. A member of the Team first needs to authorize it. |
|
Closing this PR because this review stack should target my fork first, not the original upstream repository. |
|
No problem on the close, and please do come back with it: this is one of the strongest contributions this repo has received. Zero new Rust dependencies, real scope discipline (batch only, with live and Settings UI explicitly deferred), honest docs, and the engine-neutral diagnostics refactor is valuable on its own. So you have the direction signal while you work on your fork: I'd take this as an opt-in, explicitly experimental engine, with you as the owner of the MLX bridge as mlx-audio evolves. Minutes' default path stays Python-free, which means the one thing I care most about is the setup flow's failure modes. Most Minutes users have never seen a venv, so Two mechanical notes for the re-submission: rebase on main first (transcribe.rs changed today: the whisper model now loads once per file and the chunk dispatch moved around, which touches the same area as your engine plumbing), and run If it helps to discuss design before the next PR, open an issue and tag me. Looking forward to it. |
Summary
transcription.engine = "mlx-audio"as a config-driven saved-audio transcription backend for final meeting/memo transcripts.minutes setup --mlx-audio --mlx-audio-model <id>to create/use a local Python env, installmlx-audio, save config, and run a lightweight readiness check.Scope
minutes process, desktop post-recording processing, and meeting/memo processing.minutes setupor Advanced -> Open config.Test plan
cargo check -p minutes-corecargo test -p minutes-core mlx_audio --libcargo test -p minutes-core diagnosis_uses_engine_agnostic_segment_label --libcargo test -p minutes-cli mlx_audiogit diff --check