Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 70.52% 70.50% -0.02%
==========================================
Files 386 386
Lines 32299 32313 +14
Branches 4543 4546 +3
==========================================
+ Hits 22779 22783 +4
- Misses 8472 8482 +10
Partials 1048 1048 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@mudiagaobrikisil, are you waiting on the deuterocanon PR to go through to rebase? Or why has this stalled? |
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @Enkidu93, @johnml1135, and @mudiagaobrikisil)
Previously, Enkidu93 (Eli C. Lowry) wrote…
@mudiagaobrikisil, are you waiting on the deuterocanon PR to go through to rebase? Or why has this stalled?
One of us will need to take over this PR.
62d3d58 to
45847ec
Compare
|
Addresses sillsdev/serval#477 |
45847ec to
bd4fe6d
Compare
|
OK, I rebased this. I thought we were planning on using step and total steps not a single double to communicate progress. |
|
I think our strategy might ultimately differ from the one coded in this PR. Also, the issue itself might be pushed back/might be lower priority. For those reasons, I'm going to close this. |
Made changes to the Progress Status needed to separate the progress into fineTuneProgress and inferenceProgress
This change is