python(fix): fixed grpc connection errors with missing scheme#485
Merged
python(fix): fixed grpc connection errors with missing scheme#485
Conversation
solidiquis
previously requested changes
Mar 2, 2026
tsift
reviewed
Mar 2, 2026
tsift
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who provided a url without a protocol (grpc.sift.com) instead of a full URL (https://grpc.sift.com) would get a
RuntimeError: [GrpcConnectError]: failed to connect to Sifterror without a detailed explanation as of why. This PR fixes that by automatically prependinghttps://(orhttp://whenuse_ssl=False) to the URL so the connection works regardless of whether the user includes it.Unit tests were added covering all cases for both
GrpcConfigandRestConfig(bare URLs with and without SSL, and URLs that already include the protocol). Manual testing confirmed the client connects successfully with a bare URL.