chore: spell-check all file types, not just md/mdx#533
Merged
Conversation
Previously the `includes:` in the workflow narrowed cspell scope to `**/*.md` and `**/*.mdx`, which meant typos in astro pages, tsx components, and config files went unchecked — and diverged from how other Shorebird repos run cspell. Drop the narrowing and make the existing set of files (.astro, .tsx, .mjs, package.json) pass cleanly: - Add real product / package / tool names to the words list: lavamoat, llms, opengraph, paweł, pixelmator, tabler. - Add `**/*.svg` to ignorePaths — the flagged words there come from editor-signature metadata (Pixelmator, Paweł) that churns whenever an icon is re-exported, not from authored prose. - `cspell:disable-next-line` the Unify analytics blob in Head.astro; its tracking-key fragments (Wuvn, qewe, Mpqiwu, unifytag) aren't words worth dictionary-ing.
eseidel
force-pushed
the
chore/cspell-consolidate-file-scope
branch
from
89454e0 to
bbb9388
Compare
eseidel
changed the title
easymac
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includes:narrowing from thespell-checkworkflow so cspell scans all recognized files (.astro,.tsx,.mjs,package.json, etc.), matching how other Shorebird repos run cspell.lavamoat,llms,opengraph,paweł,pixelmator,tablertowords:.**/*.svgtoignorePaths:— flagged words there are editor-signature metadata (Pixelmator,Paweł) that churns on every re-export, not authored prose.cspell:disable-next-linethe Unify analytics blob inHead.astro; its tracking-key fragments (Wuvn,qewe,Mpqiwu,unifytag) aren't dictionary-worthy words.Why
The md/mdx-only scope lived in the workflow's
includes:input, so anything invoking cspell without that input (local CLI, editor extensions, Shorebird CI) would scan every file type cspell recognizes and flag 23 pre-existing issues in 9 files. Rather than hide those issues behind a CI-only glob, fix them and let cspell catch typos in non-doc files too.Verification
npm run format:checkpasses.Test plan
buildis green.spell-check / buildis green (now scanning everything).