Open
Conversation
Contributor
atdrendel
commented
Apr 21, 2026
- Restore Phoenix reconnection backoff
- Remove race condition resulting in no reconnection attempts when a connection attempt fails
- Do not wait for channel leave to succeed before trying to rejoin the channel
There was a problem hiding this comment.
Pull request overview
This PR focuses on making Phoenix socket reconnection behavior more reliable by restoring reconnection backoff, avoiding a reconnection “stall” when an onClose happens during a failed connection attempt, and allowing channels to proceed with rejoin logic without blocking on leave completion.
Changes:
- Restores fractional reconnect backoff timing during repeated connection attempts.
- Adjusts socket close handling to avoid cancelling the reconnect task during
.connectingfailures. - Updates channel join-timeout flow to fire the leave asynchronously and immediately schedule a rejoin; adds regression tests for reconnection scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/PhoenixTests/PhoenixSocketTests.swift | Adds regression tests covering backoff application and reconnection continuation across onClose + open failures. |
| Sources/Phoenix/PhoenixSocket.swift | Fixes backoff sleep precision and adjusts close/reconnect task cancellation behavior. |
| Sources/Phoenix/PhoenixChannel.swift | Renames join-timeout error type and makes leave-after-timeout fire asynchronously to avoid blocking rejoin scheduling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ocket has received close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.