Restore volume of a VM which has been removed from a backup offering#114
Open
Pearl1594 wants to merge 1 commit intokvm-backup-plugin-shared-storagefrom
Open
Restore volume of a VM which has been removed from a backup offering#114Pearl1594 wants to merge 1 commit intokvm-backup-plugin-shared-storagefrom
Pearl1594 wants to merge 1 commit intokvm-backup-plugin-shared-storagefrom
Conversation
Member
|
@Pearl1594 let's discuss, perhaps one solution could be that the backup itself stores information about the volumes? |
Member
Author
|
Yeah, that would be more ideal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses https://shapeblue.atlassian.net/browse/FRO-3655 however, I see a possibility of regression wrt to usage - or MAYBE NOT because https://github.com/apache/cloudstack/blob/a5f55602fc3c21a56715c2b944f31c2b67f134ed/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java#L1186 lists only VMs with non null backup offering IDs and that list of VMs in turn is sent to the syncBackupMetrics() method to generate an event
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?