Merged
Conversation
jdm
approved these changes
Mar 16, 2025
Member
jdm
left a comment
There was a problem hiding this comment.
These are all reasonable choices. Thanks!
Contributor
Author
|
Awesome, thanks <3. I know this project has went through a bit of a rough patch, but I still find it very useful even in its current state. Is there any chance we could get the I would be happy to help out with any of the necessary work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the pathfinder workspace to compile and pass all tests on Linux again.
I find it very helpful to be able to run
cargo test --allin a workspace just to check if I broke anything.There were three main issues preventing this:
The
canvas_metal_minimalexample expects to link against metal specific APIs:I disabled this example on non-apple platforms in a way that's similar to how other projects like
rust-skiado this.The android demo had some minor inconsistencies (seems to not have been compiled in a while ... ;)),
so I fixed those.
The Magic Leap demo is pretty fundamentally broken. It uses nonexistant APIs and expects to call into many now private internals.
I decided to comment out it's member entry in the root workspace.
Since the hardware it was written for seems to be no longer usable, even for preexisting owners, I was hoping this would be an acceptable tradeoff. It certainly does not seem to make things worse.
With these 3 small changes you can now
cargo test --allandcargo build --allthe project on Linux again.