Skip to content

feat: Add staticChangeCount and VM service extension to DeveloperTools#341

Open
nielsenko wants to merge 2 commits intoserverpod:mainfrom
nielsenko:feat-notify-static-change
Open

feat: Add staticChangeCount and VM service extension to DeveloperTools#341
nielsenko wants to merge 2 commits intoserverpod:mainfrom
nielsenko:feat-notify-static-change

Conversation

@nielsenko
Copy link
Collaborator

@nielsenko nielsenko commented Mar 6, 2026

Description

Add staticChangeCount getter and ext.relic.notifyStaticChange VM service extension to DeveloperTools. External tools (e.g. the serverpod start --watch comand) can call the extension to notify the app of static file changes.

Related Issues

Pre-Launch Checklist

  • This update focuses on a single feature or bug fix.
  • I have read and followed the Dart Style Guide and formatted the code using dart format.
  • I have referenced at least one issue this PR fixes or is related to.
  • I have updated/added relevant documentation (doc comments with ///), ensuring consistency with existing project documentation.
  • I have added new tests to verify the changes.
  • All existing and new tests pass successfully.
  • I have documented any breaking changes below.

Breaking Changes

  • Includes breaking changes.
  • No breaking changes.

Additional Notes

None.

- Add staticChangeCount getter incremented via ext.relic.notifyStaticChange
- Register VM service extension when dev mode is active
- Add injectAt to base Router for sub-router injection
@nielsenko nielsenko self-assigned this Mar 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e81731cb-7d43-4c1a-8745-8ca698871eaa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.20%. Comparing base (0cd47b8) to head (abc6167).

Files with missing lines Patch % Lines
packages/relic_core/lib/src/router/relic_app.dart 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   91.28%   91.20%   -0.08%     
==========================================
  Files          97       97              
  Lines        3832     3844      +12     
  Branches     1953     1960       +7     
==========================================
+ Hits         3498     3506       +8     
- Misses        334      338       +4     
Flag Coverage Δ
relic_core 90.92% <66.66%> (-0.09%) ⬇️
relic_io 93.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nielsenko nielsenko requested a review from a team March 6, 2026 19:58
@nielsenko
Copy link
Collaborator Author

Again tests that depends on VmService (like hot-reload tests) are not counted in coverage currently. Please disregard the low coverage.

@nielsenko nielsenko marked this pull request as ready for review March 6, 2026 20:02
Copy link
Collaborator

@marcelomendoncasoares marcelomendoncasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants