Conversation
Major bumps: - vitest 3.2.4 → 4.1.0 - jsdom 26.1.0 → 29.0.0 - @cloudflare/workers-types 4.20260310.1 → 4.20260317.1 All 129 web tests pass with the new versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Upgrades the web/ toolchain dependencies used for JS/TS testing and Cloudflare Pages typing, aligning the web test environment with newer Vitest and jsdom major versions.
Changes:
- Bump
vitestto^4.1.0andjsdomto^29.0.0inweb/package.json. - Bump
@cloudflare/workers-typesto^4.20260317.1. - Refresh
web/package-lock.jsonto the new resolved dependency graph (including updated transitive tooling like Vite).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
web/package.json |
Updates top-level devDependencies for web tests and Cloudflare Workers typing. |
web/package-lock.json |
Updates the lockfile to reflect the new dependency resolution from the upgraded devDependencies. |
Files not reviewed (1)
- web/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
vitest 4, jsdom 29, and vite 8 (transitive) all require modern Node. Add explicit engines field so installs fail fast on unsupported versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/sensiblebit/certkit/blob/80dcb5d921f04f54e0b6c463118b130c3601b7eb/web/package.json#L13
Upgrading to jsdom@29 here silently raises the minimum Node version for the DOM-tagged tests from >=18 to ^20.19.0 || ^22.13.0 || >=24 (web/package-lock.json:921-952; the previous lockfile had jsdom@26.1.0 at >=18). Because web/package.json still has no engines field and CI only exercises lts/* in .github/workflows/ci.yml:48-53, contributors on Node 18/20.0-20.18/22.0-22.12 will only discover the break when npm ci or npm test starts failing locally.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
engines.node >= 24toweb/package.jsonSupersedes #175, #176, #177.
Test plan
🤖 Generated with Claude Code