Conversation
…r lifecycle The SeiNodeDeployment controller no longer reaches into node sidecars to submit mark-ready tasks. The SeiNode controller's NodeUpdate plan handles the full update lifecycle (apply-statefulset, observe-image, mark-ready). The deployment controller observes completion via AwaitSpecUpdate, which polls status.currentImage — a signal that is only set after the SeiNode's NodeUpdate plan fully completes, including sidecar re-initialization. Removed: - MarkNodesReady from in-place deployment plan (UpdateNodeSpecs → AwaitSpecUpdate) - MarkNodesReady task implementation, params type, constant, registry entry - MarkNodesReady tests Updated: - AwaitSpecUpdate comment documenting the boundary contract - Deployment plan test (2 tasks, not 3) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the boundary between the SeiNodeDeployment and SeiNode controllers. The deployment controller no longer reaches into node sidecars — the SeiNode controller owns the full update lifecycle via its NodeUpdate plan.
Before: Deployment plan was
UpdateNodeSpecs → AwaitSpecUpdate → MarkNodesReady(3 tasks). The deployment controller submittedmark-readydirectly to each node's sidecar.After: Deployment plan is
UpdateNodeSpecs → AwaitSpecUpdate(2 tasks).AwaitSpecUpdatepollsstatus.currentImage, which the SeiNode controller only stamps after its NodeUpdate plan completes — includingmark-ready.Boundary model
spec.imageon child nodes, waits forstatus.currentImageto convergecurrentImageRemoved
MarkNodesReadytask implementation, params, constant, registry entry, tests (-138 lines)Test plan
make build && make test && make lint— all green🤖 Generated with Claude Code