refactor: planner owns condition management, not executor#92
Merged
Conversation
Move condition ownership from the executor to the planner. The executor now only mutates plan/task state and phase transitions. The planner sets conditions when creating plans and when observing terminal plans on the next reconcile. - Remove setPlanFailedCondition from executor - Remove ConditionPlanFailed constant from executor - Update failTask doc to clarify planner handles conditions - Update planner doc.go with condition ownership section - Update CLAUDE.md Key Patterns with condition ownership, atomic plan creation, and single-patch model documentation - Update test to assert plan failure details instead of condition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves condition ownership from the executor to the planner. This is a strategy shift in preparation for NodeUpdate plans — the planner is the component that understands what plans mean, so it should own the conditions that signal plan state to external observers.
setPlanFailedCondition,ConditionPlanFailed.NodeUpdateInProgress=True) and when observing terminal plans on the next reconcile (e.g.,NodeUpdateInProgress=False, Reason=UpdateCompleteorReason=UpdateFailed).doc.goandCLAUDE.mdwith condition ownership, atomic plan creation, and single-patch model patterns.Ownership model
Test plan
make build && make test && make lint— all green🤖 Generated with Claude Code