Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
==========================================
+ Coverage 57.22% 57.26% +0.04%
==========================================
Files 2094 2091 -3
Lines 171956 171769 -187
==========================================
- Hits 98400 98369 -31
+ Misses 64739 64638 -101
+ Partials 8817 8762 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aa67afc to
6444c32
Compare
wen-coding
reviewed
Feb 17, 2026
| func MakeRollbackStateCommand(conf *config.Config) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "rollback", | ||
| Short: "rollback tendermint state by one height", |
Contributor
There was a problem hiding this comment.
Why are we removing rollback commands as well? This only works on tendermint binary?
Contributor
Author
There was a problem hiding this comment.
there are 2 rollback commands and seid is using just 1 of them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tendermint binary was unused (only some of its commands are imported by seid binary). abciclient was an unncessary abstraction because seid works only with LocalClient which is a noop wrapper.