Skip to content

removed tendermint binary and abciclient.#2909

Open
pompon0 wants to merge 13 commits intomainfrom
gprusak-abci
Open

removed tendermint binary and abciclient.#2909
pompon0 wants to merge 13 commits intomainfrom
gprusak-abci

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Feb 17, 2026

tendermint binary was unused (only some of its commands are imported by seid binary). abciclient was an unncessary abstraction because seid works only with LocalClient which is a noop wrapper.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 18, 2026, 10:03 AM

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.26%. Comparing base (07025b9) to head (cf745c0).

Files with missing lines Patch % Lines
sei-tendermint/internal/proxy/client.go 68.75% 5 Missing ⚠️
sei-tendermint/cmd/tendermint/commands/config.go 42.85% 2 Missing and 2 partials ⚠️
sei-tendermint/internal/consensus/replay_stubs.go 33.33% 4 Missing ⚠️
sei-tendermint/abci/tests/server/client.go 0.00% 3 Missing ⚠️
sei-cosmos/server/start.go 0.00% 1 Missing ⚠️
sei-tendermint/node/public.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2909      +/-   ##
==========================================
+ Coverage   57.22%   57.26%   +0.04%     
==========================================
  Files        2094     2091       -3     
  Lines      171956   171769     -187     
==========================================
- Hits        98400    98369      -31     
+ Misses      64739    64638     -101     
+ Partials     8817     8762      -55     
Flag Coverage Δ
sei-chain 52.73% <57.14%> (-0.01%) ⬇️
sei-cosmos 48.19% <0.00%> (ø)
sei-db 68.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/cmd/tendermint/commands/rollback.go 0.00% <ø> (-11.43%) ⬇️
sei-tendermint/cmd/tendermint/commands/run_node.go 100.00% <ø> (+42.26%) ⬆️
sei-tendermint/config/db.go 100.00% <ø> (ø)
sei-tendermint/internal/consensus/replay.go 74.89% <100.00%> (-0.82%) ⬇️
sei-tendermint/internal/mempool/mempool.go 71.95% <ø> (-0.47%) ⬇️
sei-tendermint/internal/mempool/mocks/mempool.go 10.20% <ø> (-2.54%) ⬇️
sei-tendermint/internal/mempool/types.go 64.70% <ø> (ø)
sei-tendermint/internal/rpc/core/env.go 75.49% <ø> (ø)
sei-tendermint/internal/state/execution.go 81.17% <100.00%> (+0.75%) ⬆️
sei-tendermint/internal/state/metrics.gen.go 14.45% <ø> (+0.01%) ⬆️
... and 13 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 changed the title removed abstraction from node.New removed tendermint binary and abciclient. Feb 17, 2026
@pompon0 pompon0 marked this pull request as ready for review February 17, 2026 21:06

// Commit block, get hash back
start = time.Now()
start := time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
func MakeRollbackStateCommand(conf *config.Config) *cobra.Command {
cmd := &cobra.Command{
Use: "rollback",
Short: "rollback tendermint state by one height",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing rollback commands as well? This only works on tendermint binary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 rollback commands and seid is using just 1 of them

Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay; less is more 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants