Skip to content

perf: optimize pngs#11

Open
Commenter25 wants to merge 2 commits intosecureblue:livefrom
Commenter25:compression-continuation
Open

perf: optimize pngs#11
Commenter25 wants to merge 2 commits intosecureblue:livefrom
Commenter25:compression-continuation

Conversation

@Commenter25
Copy link
Copy Markdown

Description from secureblue/secureblue.dev#346 applies to this as well 😄

With one exception: In the second commit, I ran it again with --alpha/-a, which checks for 100% transparent pixels, and removes the invisible color data. This does not affect how the image appears, and shouldn't affect anything unless something is pulling a Spore. That said, it is technically a lossy operation, so I wanted to point it out and make it easy to revert just in case.

The previous PR had no transparent images, so this flag did not apply. In this case, it's the opposite, all of them have transparency.

Without --alpha:

Input size: 827 KiB (846742 bytes)
Output size: 597 KiB (611500 bytes)
Total saved: 230 KiB (27.78%)

Running again with --alpha:

Input size: 597 KiB (611500 bytes)
Output size: 586 KiB (600269 bytes)
Total saved: 11.0 KiB (1.84%)

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes this insignificant, might as well leave them unchanged

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? /genq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants