Info form

[catreedle]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the xcodebuild and swiftlint --strict commands as directed in the testing section of the contributing guide

---

Description

This PR removes old in-command state keyboard setups from Keyboard.xib and KeyboardViewController and refactor "Not in wikidata" info tooltip to use dynamic key form view.

Changes:

• Remove unused keys elements from Keyboard.xib, its contraints and fix constraint
• Remove unused keys elements initiation, its setup, and related functions from KeyboardViewController, change how information tooltip is shown
• Set up showing information tooltip in DynamicConjugationViewController.swift and NavigationStructure.swift
• Delete ToolTipViewDatasource.swift, ToolTipViewTheme.swift, ToolTipViewDatasourceable.swift, ToolTipViewUpdatable.swift, ViewThemeable.swift, ToolTipView.swift that are no longer used

Related issue

• Remove XIB-based 1x1 form display and convert to programmatic UI #594

[github-actions]

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

So great to have this, @catreedle! Do you want to maybe add in the work for #597 here? I'm realizing we need strings for the "Not in Wiktionary" description for the user. I can add those into Scribe-i18n now and maybe we can make the change so that all of this part is finalized?

[andrewtavis]

The latest commit to main updated Scribe-i18n, @catreedle :) Feel free to use those new strings for the message about Wiktionary not being available, and for the Not in Wiktionary you can just translate the strings for the interface fields :)

[andrewtavis]

Please let me know if you have questions or if you'd prefer to prioritize something else!

[catreedle]

Please let me know if you have questions or if you'd prefer to prioritize something else!

Thank you! I will look into this soon. :)

[catreedle]

hi @andrewtavis the change applies to only translation command, right?
conjugate and plural will still use the old messages?

[andrewtavis]

Yes exactly, @catreedle 😊

[catreedle]

Yes exactly, @catreedle 😊

Okay. working on it :)

[catreedle]

still need to look into the localization, currently the invalid description is always using fallback value.

[catreedle]

it seems that for wikidata, the invalid description follows device's language, not the Scribe's keyboard language. Which language should it follow @andrewtavis ?
as for the wiktionary localizations, it needs to be generated for other languages besides English. is there a script for this?

[andrewtavis]

We don't have a script for this, @catreedle. We can just use an online translator for some of these scripts :) If there's an issue, it can be fixed by the community. We can also check the languages we all speak 😊

[andrewtavis]

Feel free to send along the translations and we should be good to go after that!

[andrewtavis]

Notes from the sync: We do need these texts coming from Scribe-i18n, and for now they do not need to be localized. If they don't have a text in a locale, then it should be defaulted to English :)

What was writtne out:

• We should only use the keyboard language
• Do we hard code the "Not in..." texts into the interface variables, or do we use Scribe-i18n?
• If we do have localizations for the strings in the keyboard language, then put them in the interface file
• If we don't, let's hard code them and translate them
• If we don't have the keyboard, but we do have the localization, then let's make an interface file and just save the strings in the needed variables so that these localizations don't go to waste
• Then we delete the following strings from Scribe-i18n:
  • i18n.app.keyboard.not_in_wikidata.explanation_1
  • i18n.app.keyboard.not_in_wikidata.explanation_2
  • i18n.app.keyboard.not_in_wikidata.explanation_3
  • i18n.app.keyboard.not_in_wiktionary.explanation_1
  • i18n.app.keyboard.not_in_wiktionary.explanation_2
  • i18n.app.keyboard.not_in_wiktionary.explanation_3