Conversation
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Prepare for transition to using Wiktionary for translations by replacing all "not_in_wikidata" string keys with "not_in_wiktionary" across all language interface files and UI components. Changes apply to: - 17 language-specific string.xml files - KeyboardUIManager.kt UI component Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Hey, @andrewtavis pls review and let me know in case of any changes! |
|
Thanks for the PR here, @Mounil2005 :) We have a couple of instructions here based on a discussion we had in our most recent dev sync:
Could you do the following:
CC @catreedle and @angrezichatterbox 👋 Hope the above makes sense to you two :) |
|
Got it, working on it! |
Signed-off-by: Mounil <mounilkankhara@gmail.com>
|
Hey @andrewtavis, I have implemented the changes, pls let me know in case of any changes!! |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request prepares Scribe-Android for the migration from Wikidata to Wiktionary as the data source for translations. All string references have been updated from
not_in_wikidatatonot_in_wiktionary.Main changes:
string.xmlfiles (Arabic, Bengali, German, Spanish, French, Hindi, Indonesian, Kannada, Korean, Marathi, Portuguese, Swedish, Tamil, Telugu, Turkish, and English)KeyboardUIManager.ktto reference the new Wiktionary string keysThe string content itself remains unchanged as it will be updated separately. These changes ensure the app infrastructure is ready to display Wiktionary-related messages when the backend switches to that data source.
Related issue