feat: unify ArksApplication on RBG v0.6.0#79
Open
LikiosSedo wants to merge 8 commits intoscitix:mainfrom
Open
Conversation
- Adapt to RBG v0.5.0 pointer type API changes - Add CoordinationPolicy with Scaling and RollingUpdate strategies - Scaling: coordinated initial deployment and scale-up - RollingUpdate: coordinated rolling updates (Issue #150) - CoordinationPolicy is independent of PodGroupPolicy
- Switch rbg dependency from internal GitLab to official GitHub v0.6.0 - Adapt RoleSpec.Template to RoleSpec.TemplateSource.Template for KEP-8 RoleTemplate support in arksapplication and arksdisaggregatedapplication controllers
Add rbgsSpecSemanticallyEqual() to compare RBGS specs by JSON semantic equality before patching. This prevents unnecessary PATCH requests caused by Go type-level differences (pointer vs value) when upgrading across RBG API versions (v0.5.0 → v0.6.0). Also explicitly set Partition=0 on scheduler/router roles to match the CRD-defaulted value in stored RBGS, eliminating false diffs that would trigger a reconcile cascade and recreate downstream pods.
LikiosSedo
force-pushed
the
pr-unified-rbg060-clean
branch
from
39f624e to
79f92b6
Compare
- Extract isArksAppReady() to utils.go as single source of truth for ArksApplication readiness, used by both application and endpoint controllers. - Hoist label map generation outside loops in generateRouterCommand() to avoid redundant allocations on each iteration.
When router.image and router.commandOverride are both provided, bypass the sglang-only validation and use the user-supplied command directly. This enables non-sglang runtimes (vllm, dynamo) to use a custom router deployment.
Rebuild dist/operator.yaml to include unified ArksApplication CRD changes and new RBAC rules. Default image placeholder unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArksApplicationinto the unified inference entrypointmode=unified|disaggregatedinArksApplicationArksDisaggregatedApplicationas the legacy-compatible pathArksApplicationtop-level status summaryValidation
Validated on test cluster:
ArksDisaggregatedApplicationresources survive upgrade fromarks 0.2.2 + rbg050 alpha4toarks_pr + rbg060ArksApplication(mode=disaggregated)can be created after upgradeNotes
Not included in this PR: