✨ S3UTILS-230 implement CRR multi-site V2 replication format#396
✨ S3UTILS-230 implement CRR multi-site V2 replication format#396DarkIsDude wants to merge 4 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/1 #396 +/- ##
=================================================
+ Coverage 44.90% 45.47% +0.56%
=================================================
Files 88 88
Lines 6456 6547 +91
Branches 1352 1373 +21
=================================================
+ Hits 2899 2977 +78
- Misses 3511 3521 +10
- Partials 46 49 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d5490b8 to
f9fca0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
maeldonn
left a comment
There was a problem hiding this comment.
Can be simplified a lot by using arsenal logic
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following reviewers are expecting changes from the author, or must review again: |
This comment was marked as resolved.
This comment was marked as resolved.
| "@smithy/util-retry": "^4.0.7", | ||
| "JSONStream": "^1.3.5", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.2.36", | ||
| "arsenal": "git+https://github.com/scality/Arsenal#improvement/ARSN-571/crr-multi", |
There was a problem hiding this comment.
arsenal is pinned to branch improvement/ARSN-571/crr-multi instead of a version tag. Git-based deps (arsenal, vaultclient, bucketclient, werelogs, httpagent) must pin to a tag for reproducible builds — a branch ref means different builds can resolve to different commits.
```suggestion
"arsenal": "git+https://github.com/scality/Arsenal#",
|
Summary
Changes
`CRR/ReplicationStatusUpdater.js`
`package.json` — arsenal pinned to `improvement/ARSN-571/crr-multi` for the new static methods
`tests/utils/crr.js` — V2 bucket replication config fixture
`tests/unit/CRR/ReplicationStatusUpdater.js` — 7 new V2 test cases (single match, dual-rule prefix overlap, no-match skip, SITE_NAME filter, all-up-to-date skip, PROCESSING aggregate status, forceUsingConfiguration)
Test plan
Issue: S3UTILS-230
:80. Should we ping CS or update the page directly ?