Skip to content

Inhibit the dismissal of the popover when a select option is clicked.#258

Open
vanboom wants to merge 3 commits into
sandywalker:masterfrom
vanboom:master
Open

Inhibit the dismissal of the popover when a select option is clicked.#258
vanboom wants to merge 3 commits into
sandywalker:masterfrom
vanboom:master

Conversation

@vanboom

@vanboom vanboom commented Dec 1, 2017

Copy link
Copy Markdown

The pointer event point is 0,0 when a select option contained within the popover is clicked. Inhibit the dismissal of the popover based on this.

The pointer event point is 0,0 when a select option contained within the popover is clicked.  Inhibit the dismissal of the popover based on this.
@vanboom vanboom changed the title Inhibit the dismissal of the popover when a select option is clicked. #257 Inhibit the dismissal of the popover when a select option is clicked. Dec 1, 2017
@anatolesaby

Copy link
Copy Markdown

+1

@yesitsfebreeze

Copy link
Copy Markdown

@vanboom you should also add a check for the nodeType or else it wont work in IE.

if ((pt.x === 0 && pt.y === 0) || event.target.nodeName === 'OPTION')

@ayjee

ayjee commented Mar 27, 2019

Copy link
Copy Markdown

+1

q2apro pushed a commit to q2apro/webui-popover that referenced this pull request Aug 15, 2019
sandywalker#258

vanboom on Dec 1, 2017
Douglas Pouk on Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants