Parse harmony (chord symbols) from MusicXML files#83
Open
maximoskp wants to merge 12 commits intosalu133445:mainfrom
Open
Parse harmony (chord symbols) from MusicXML files#83maximoskp wants to merge 12 commits intosalu133445:mainfrom
maximoskp wants to merge 12 commits intosalu133445:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I made a version that produces a
Harmonyfield inTrackobjects.Harmonyincludes an array of objects of a new class that I namedChordSymbol.An "intermediate" class
ChordSymbolParsesis used inutils.pythat extract all the relevant MusicXML information for chords ("harmony" tag). This feeds theChordSymbolobjects with several information, including anmir_eval-compatible chord representation.Therefore, this version requires
mir_eval- specifically, a version ofmir_evalthat fixes a "bug" that prevented encoding some chord types. This version ofmir_evalcan be found here:https://github.com/maximoskp/mir_eval/tree/allchordtypes
I've created a pull request for that recently in
mir_eval, so it will possibly be available in the main branch of ```mir_eval`` soon.I know that I didn't follow the high code and testing standards of the
muspyrepository, so I will be clad to receive any feedback and try again. Needless to say, you can do whatever you want with the current version of the code that I submit through this pull request. Thanks!