Skip to content

fix: recognize swarm provisioning values#617

Open
NgoQuocViet2001 wants to merge 1 commit into
ruvnet:mainfrom
NgoQuocViet2001:fix/provision-swarm-config-detection
Open

fix: recognize swarm provisioning values#617
NgoQuocViet2001 wants to merge 1 commit into
ruvnet:mainfrom
NgoQuocViet2001:fix/provision-swarm-config-detection

Conversation

@NgoQuocViet2001
Copy link
Copy Markdown
Contributor

Summary

  • Treat --hop-channels, --seed-token, --swarm-hb, and --swarm-ingest as real provisioning values in provision.py's empty-config guard.
  • Move that guard into a small has_config_value() helper so the CLI value check can be regression-tested.
  • Add Python tests covering swarm bridge / channel hopping flags and CSV output.

Why

Issue #574 calls out the esp32-csi-node swarm bridge provisioning path, including seed credentials and heartbeat/ingest settings. The script already writes these fields to NVS, but the preflight guard did not count several of them as config values. A partial invocation such as --seed-token ... --force-partial could therefore fail with At least one config value must be specified before CSV generation.

This keeps the existing full-replace safety guard intact; it only fixes the false "no config" rejection for fields that are already supported by build_nvs_csv().

Validation

  • python -m unittest discover -s firmware\esp32-csi-node\tests -p "test_*.py"
  • python -m py_compile firmware\esp32-csi-node\provision.py firmware\esp32-csi-node\tests\test_provision.py
  • git diff --check

Duplicate check

Searched existing PRs for provision.py, csi_cfg, full-replace, and seed_url overlap; did not find an open or recent PR covering this guard bug.

Refs #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant