fix: recognize swarm provisioning values#617
Open
NgoQuocViet2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hop-channels,--seed-token,--swarm-hb, and--swarm-ingestas real provisioning values inprovision.py's empty-config guard.has_config_value()helper so the CLI value check can be regression-tested.Why
Issue #574 calls out the
esp32-csi-nodeswarm bridge provisioning path, including seed credentials and heartbeat/ingest settings. The script already writes these fields to NVS, but the preflight guard did not count several of them as config values. A partial invocation such as--seed-token ... --force-partialcould therefore fail withAt least one config value must be specifiedbefore CSV generation.This keeps the existing full-replace safety guard intact; it only fixes the false "no config" rejection for fields that are already supported by
build_nvs_csv().Validation
python -m unittest discover -s firmware\esp32-csi-node\tests -p "test_*.py"python -m py_compile firmware\esp32-csi-node\provision.py firmware\esp32-csi-node\tests\test_provision.pygit diff --checkDuplicate check
Searched existing PRs for
provision.py,csi_cfg,full-replace, andseed_urloverlap; did not find an open or recent PR covering this guard bug.Refs #574