fix(docs): correct ADR cross-references in ADR-006 Related field#355
Open
sebastianricaldoni wants to merge 1 commit intoruvnet:mainfrom
Open
fix(docs): correct ADR cross-references in ADR-006 Related field#355sebastianricaldoni wants to merge 1 commit intoruvnet:mainfrom
sebastianricaldoni wants to merge 1 commit intoruvnet:mainfrom
Conversation
The Related field incorrectly referenced ADR-003 as KV Cache and ADR-005 as LoRA Adapter Loading. In the actual repo: - ADR-003 is SIMD Optimization Strategy - ADR-004 is KV Cache Management (correct target) - ADR-005 is WASM Runtime Integration (correct name) No LoRA Adapter Loading ADR exists; ADR-005 (WASM) is the genuine related decision for memory management concerns. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
I wasn't sure if there was a specific format used for the ADRs. I did look at a few and it did seem that they all had different structure. Perhaps it is better to keep a single section where to reference other ADRs? I saw that being the case in others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-003 (KV Cache)was wrong — ADR-003 is SIMD Optimization Strategy; KV Cache is ADR-004ADR-005 (LoRA Adapter Loading)was wrong — ADR-005 is WASM Runtime Integration; no dedicated LoRA Adapter Loading ADR exists in the repoThe bottom "Related Decisions" section of the same file already correctly referenced ADR-004, making the frontmatter table internally inconsistent.
Changes
docs/adr/ADR-006-memory-management.md— one line in the frontmatter table:Test plan
🤖 Generated with claude-flow