der: Reject non-canonical encoding of bit strings.#484
Open
briansmith wants to merge 4 commits intorustls:mainfrom
Open
der: Reject non-canonical encoding of bit strings.#484briansmith wants to merge 4 commits intorustls:mainfrom
briansmith wants to merge 4 commits intorustls:mainfrom
Conversation
Also test the cases where only a single padding bit is nonzero, in addition to the existing test case where all the padding bits are nonzero.
…bytes. I had trouble reading the previous implementation of the function, so I tried to clarify the control flow. Along the way, I noticed that there is a missing case. I think this new control flow is much clearer. Also fix the misleading comment "If there are padding bits then the last bit of the last raw byte must be 0": Actually all the padding bits must be zero, which was what was correctly being checked.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 96.97% 96.98% +0.01%
==========================================
Files 20 20
Lines 3936 3953 +17
==========================================
+ Hits 3817 3834 +17
Misses 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/bit-string-clarification
branch
from
d3c23ec to
a46879f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each individual commit message. Note that originally I just wanted to clarify the control flow, but in the process I noticed this improvement needs to be made. I think this new control flow is clearer, so I didn't try to fix the issue with the old control flow.