tests: avoid vendored limbo.json#480
Merged
cpu merged 1 commit intorustls:mainfrom Apr 21, 2026
Merged
Conversation
The upstream harness support crate we take a dev git-dep on added an embedded copy of the limbo.json test data, so we don't need to vendor it anymore. With both that usage and the older bettertls vendored data removed we can also drop the dev dep on bzip2. This approach has the advantage of being easier to keep in sync with upstream, we just have to bump the Cargo.toml dev dep SHA.
cpu
force-pushed
the
ci/cpu-simplify-limbo
branch
from
06b8e4c to
059879a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 20 20
Lines 3936 3936
=======================================
Hits 3817 3817
Misses 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
approved these changes
Apr 21, 2026
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream harness support crate we take a dev git-dep on added an embedded copy of the limbo.json test data (C2SP/x509-limbo#600), so we don't need to vendor it anymore. With both that usage and the older bettertls vendored data removed we can also drop the dev dep on bzip2.
This approach has the advantage of being easier to keep in sync with upstream, we just have to bump the Cargo.toml dev dep SHA.