test: Allow multiple issuer items of the same kind#415
Open
da-kami wants to merge 1 commit intorustls:multi-namesfrom
Open
test: Allow multiple issuer items of the same kind#415da-kami wants to merge 1 commit intorustls:multi-namesfrom
da-kami wants to merge 1 commit intorustls:multi-namesfrom
Conversation
2807a85 to
c17014b
Compare
c17014b to
a2b7191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@djc please let me know if this is in line with what you guys had in mind for a "roundtrip" test for #394
Note:
I think it would be great to add another test to the
openssltests using the test cert of my original test in #301 but I was not sure if it was "acceptable" to paste a cert into those test and how to best set it up in theverify-testscrate.I initially had written a test in
certificate.rsusing the cert generated with openssl, but I suppose that's not what you guys had in mind in terms of internal roundtrip, so I changed it.(Sidenote: the test with the openssl cert was passing as well)
Test cert for reference: