Implement float math functions for two arrays#1516
Open
Waterdragen wants to merge 8 commits intorust-ndarray:masterfrom
Open
Implement float math functions for two arrays#1516Waterdragen wants to merge 8 commits intorust-ndarray:masterfrom
Waterdragen wants to merge 8 commits intorust-ndarray:masterfrom
Conversation
Collaborator
|
Can you please add one test for at least one of those functions? |
Contributor
Author
|
Hi there! I've added a test for |
Collaborator
|
LGTM. I'll leave time for the other maintainers to react, if need be, then I'll merge. |
Collaborator
|
I'm not sure this is the right approach here. If we grant that we want this (and I think we do?) I'd rather we take advantage of generics and traits to make it happen. I had a working example at #1469 of what this might look like. We also should consider whether a method like this should perform broadcasting for the user or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Since we have something like
array.binary_fn(float), we could also havearray.binary_fn(array).Extends functionality of #1042 and #1507
New binary methods for RHS = float
New binary methods for RHS = arrays