Convert the FreeBSD tests to Github Workflows#651
Merged
Thomasdezeeuw merged 1 commit intorust-lang:masterfrom Apr 20, 2026
Merged
Convert the FreeBSD tests to Github Workflows#651Thomasdezeeuw merged 1 commit intorust-lang:masterfrom
Thomasdezeeuw merged 1 commit intorust-lang:masterfrom
Conversation
asomers
force-pushed
the
github-workflows
branch
from
2ad4445 to
777a158
Compare
Because Cirrus Labs is shutting down soon. Fixes rust-lang#649
asomers
force-pushed
the
github-workflows
branch
from
777a158 to
f74eb7a
Compare
xtqqczze
reviewed
Apr 17, 2026
Comment on lines
+182
to
+183
| . $HOME/.cargo/env | ||
| rustup target add ${{ matrix.target }} |
There was a problem hiding this comment.
Suggested change
| . $HOME/.cargo/env | |
| rustup target add ${{ matrix.target }} | |
| # i686-unknown-freebsd runs on x86_64 using 32-bit compatibility, so the target must be added explicitly. | |
| if [ "${{ matrix.target }}" = "i686-unknown-freebsd" ]; then | |
| . $HOME/.cargo/env | |
| rustup target add i686-unknown-freebsd | |
| fi |
Collaborator
There was a problem hiding this comment.
This suggestion is what we do for Mio as well.
Thomasdezeeuw
approved these changes
Apr 20, 2026
Collaborator
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Still haven't had time to properly review vmactions/freebsd-vm, but since we've switched Tokio and Mio already I'm ok with merging this.
Comment on lines
+182
to
+183
| . $HOME/.cargo/env | ||
| rustup target add ${{ matrix.target }} |
Collaborator
There was a problem hiding this comment.
This suggestion is what we do for Mio as well.
Collaborator
|
Thanks @asomers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Cirrus Labs is shutting down soon.
Fixes #649