Rename IntoOverflowableItem to satisfy clippy#5924
Open
kadiwa4 wants to merge 1 commit intorust-lang:mainfrom
Open
Rename IntoOverflowableItem to satisfy clippy#5924kadiwa4 wants to merge 1 commit intorust-lang:mainfrom
IntoOverflowableItem to satisfy clippy#5924kadiwa4 wants to merge 1 commit intorust-lang:mainfrom
Conversation
kadiwa4
force-pushed
the
clippy_portion
branch
from
9e80b51 to
ef5a09e
Compare
kadiwa4
force-pushed
the
clippy_portion
branch
from
ef5a09e to
578d753
Compare
kadiwa4
force-pushed
the
clippy_portion
branch
from
578d753 to
41ff220
Compare
jieyouxu
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5400 isn't making progress, so here's one of the commits split out.
into_…is supposed to be used by functions that consumeself, howeverinto_overflowable_itemborrowsself.