Inline WorkerThread pointer into a thread local#155688
Open
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
Open
Inline WorkerThread pointer into a thread local#155688zetanumbers wants to merge 1 commit intorust-lang:mainfrom
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @nnethercote |
Contributor
Author
|
Doesn't seem to influence the performance overall, but noise level is a bit too big on my machine. Perhaps @Zoxc has better environment.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Also I haven't yet updated comments. TODO |
Contributor
|
I was thinking a scoped thread local would make sense for this too. cc @cuviper in case that makes sense for upstream Rayon. My guess is that the indirection doesn't have much performance overhead. A Rayon benchmark would be more suitable, but not sure it would pick that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got this idea while implementing #155649. It's not as clean as I've expected but it did get rid of many unsafe blocks. I can also remove these unsafe blocks without changing
WORKER_THREAD_STATE's type by utilizing new safeWorkerThreadfunctions.