Skip to content

experiment: single owner query#155678

Draft
aerooneqq wants to merge 5 commits intorust-lang:mainfrom
aerooneqq:single-owners-query-exp
Draft

experiment: single owner query#155678
aerooneqq wants to merge 5 commits intorust-lang:mainfrom
aerooneqq:single-owners-query-exp

Conversation

@aerooneqq
Copy link
Copy Markdown
Contributor

@aerooneqq aerooneqq commented Apr 23, 2026

Now five queries (local_def_id_to_hir_id, opt_hir_owner_nodes, hir_attr_map, opt_ast_lowering_delayed_lints, in_scope_traits_map) were replaced with regular methods which acts like getters, depending on the perf run maybe caches will be added for them.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 23, 2026
@rust-log-analyzer

This comment has been minimized.

@aerooneqq aerooneqq force-pushed the single-owners-query-exp branch from 7b9e758 to 67a6a79 Compare April 23, 2026 09:24
@petrochenkov
Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 23, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Apr 23, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 23, 2026

☀️ Try build successful (CI)
Build commit: a7e17f9 (a7e17f9dcdebc727f983dd75b86950023250e23a, parent: 92c7010294007f9bb819f0ddd9d9e9b5ccd5714a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a7e17f9): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
42.5% [0.3%, 107.3%] 7
Regressions ❌
(secondary)
27.3% [0.0%, 106.5%] 10
Improvements ✅
(primary)
-1.1% [-2.6%, -0.2%] 111
Improvements ✅
(secondary)
-1.6% [-5.3%, -0.2%] 68
All ❌✅ (primary) 1.4% [-2.6%, 107.3%] 118

Max RSS (memory usage)

Results (primary 1.5%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
17.4% [9.5%, 28.4%] 6
Regressions ❌
(secondary)
4.6% [2.3%, 7.3%] 10
Improvements ✅
(primary)
-1.2% [-2.2%, -0.6%] 36
Improvements ✅
(secondary)
-4.1% [-6.8%, -1.8%] 14
All ❌✅ (primary) 1.5% [-2.2%, 28.4%] 42

Cycles

Results (primary 40.1%, secondary 5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
61.3% [9.7%, 117.9%] 6
Regressions ❌
(secondary)
19.9% [1.8%, 63.2%] 10
Improvements ✅
(primary)
-2.3% [-2.6%, -2.1%] 3
Improvements ✅
(secondary)
-3.8% [-5.3%, -1.5%] 16
All ❌✅ (primary) 40.1% [-2.6%, 117.9%] 9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 500.795s -> 487.693s (-2.62%)
Artifact size: 394.31 MiB -> 394.27 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 23, 2026
@aerooneqq aerooneqq force-pushed the single-owners-query-exp branch from 55f2f15 to 69beb66 Compare April 24, 2026 11:09
@aerooneqq aerooneqq force-pushed the single-owners-query-exp branch from 69beb66 to 464a7a0 Compare April 24, 2026 11:17
@petrochenkov
Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 24, 2026
rust-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

☀️ Try build successful (CI)
Build commit: 7769c1a (7769c1a185b3989b2a2bf22894bf03f2b0505c4c, parent: cf79d034aa3d8f396d407aafce6f1ccd818e710e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7769c1a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.0%, 0.6%] 4
Improvements ✅
(primary)
-0.8% [-1.7%, -0.2%] 99
Improvements ✅
(secondary)
-1.0% [-2.8%, -0.0%] 56
All ❌✅ (primary) -0.8% [-1.7%, -0.2%] 99

Max RSS (memory usage)

Results (primary -0.0%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [1.0%, 3.5%] 2
Regressions ❌
(secondary)
3.9% [2.3%, 7.4%] 6
Improvements ✅
(primary)
-0.8% [-0.9%, -0.6%] 6
Improvements ✅
(secondary)
-2.0% [-2.3%, -1.5%] 3
All ❌✅ (primary) -0.0% [-0.9%, 3.5%] 8

Cycles

Results (primary -2.9%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [1.3%, 6.8%] 4
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
-2.8% [-3.5%, -1.3%] 8
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Binary size

Results (primary -0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 11
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 4
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 11

Bootstrap: 493.065s -> 491.562s (-0.30%)
Artifact size: 394.27 MiB -> 394.23 MiB (-0.01%)

@rustbot rustbot removed perf-regression Performance regression. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 24, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 25, 2026

☔ The latest upstream changes (presumably #155460) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants