Conversation
This comment has been minimized.
This comment has been minimized.
7b9e758 to
67a6a79
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
experiment: single owner query
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (a7e17f9): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.5%, secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 40.1%, secondary 5.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 500.795s -> 487.693s (-2.62%) |
55f2f15 to
69beb66
Compare
69beb66 to
464a7a0
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
experiment: single owner query
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7769c1a): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.0%, secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.9%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 493.065s -> 491.562s (-0.30%) |
|
☔ The latest upstream changes (presumably #155460) made this pull request unmergeable. Please resolve the merge conflicts. |
Now five queries (
local_def_id_to_hir_id,opt_hir_owner_nodes,hir_attr_map,opt_ast_lowering_delayed_lints,in_scope_traits_map) were replaced with regular methods which acts like getters, depending on the perf run maybe caches will be added for them.r? @petrochenkov