Skip to content

enable dynamic linking on the vita target#155563

Closed
olebeck wants to merge 1 commit intorust-lang:mainfrom
olebeck:enable-vita-dynamic-linking
Closed

enable dynamic linking on the vita target#155563
olebeck wants to merge 1 commit intorust-lang:mainfrom
olebeck:enable-vita-dynamic-linking

Conversation

@olebeck
Copy link
Copy Markdown

@olebeck olebeck commented Apr 20, 2026

the vita os has support for dynamic linking so this should be set enabled on the target definition

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 17 candidates

@petrochenkov
Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 20, 2026

📌 Commit bdc4a72 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2026
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
Executing "/scripts/stage_2_test_set2.sh"
+ /scripts/stage_2_test_set2.sh
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
PR_CI_JOB set; skipping tidy
+ ../x.py --stage 2 test --skip tidy --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 20, 2026
…g, r=petrochenkov

enable dynamic linking on the vita target

the vita os has support for dynamic linking so this should be set enabled on the target definition
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors r-
#155566 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 20, 2026

This pull request was unapproved.

This PR was contained in a rollup (#155566), which was unapproved.

@olebeck olebeck marked this pull request as draft April 20, 2026 21:25
@petrochenkov
Copy link
Copy Markdown
Contributor

(The draft status is unnecessary, the S-waiting-on-* labels are enough.)

@olebeck
Copy link
Copy Markdown
Author

olebeck commented Apr 21, 2026

misunderstood what rustc meant by dynamic

@olebeck olebeck closed this Apr 21, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants