Skip to content

cg_clif: Don't show verbose run-make cmd output for passing tests#155220

Open
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
jieyouxu:dont-verbose-print-success-cg-clif
Open

cg_clif: Don't show verbose run-make cmd output for passing tests#155220
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
jieyouxu:dont-verbose-print-success-cg-clif

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Apr 13, 2026

Uses --verbose-run-make-subprocess-output=false added in #154587 to suppress verbose cmd dump for passing run-make tests.

Closes #154069.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 13, 2026
@jieyouxu jieyouxu force-pushed the dont-verbose-print-success-cg-clif branch from 98bfbb0 to 30db41d Compare April 14, 2026 01:22
@jieyouxu jieyouxu marked this pull request as ready for review April 14, 2026 01:34
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2026
@rustbot

This comment was marked as outdated.

@jieyouxu
Copy link
Copy Markdown
Member Author

Sorry, forgot to assign...
r? bjorn3

@rustbot rustbot assigned bjorn3 and unassigned adwinwhite Apr 14, 2026
@jieyouxu jieyouxu removed A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide labels Apr 14, 2026

echo "[TEST] rustc test suite"
./x.py test --stage 0 --test-args=--no-capture tests/{codegen-units,run-make,run-make-cargo,ui,incremental}
./x.py test --stage 0 --no-capture --verbose-run-make-subprocess-output=false tests/{codegen-units,run-make,run-make-cargo,ui,incremental}
Copy link
Copy Markdown
Member Author

@jieyouxu jieyouxu Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

(Could you double-check if this goes back to the behavior that you wanted?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retain ability to not verbose-dump cmd/output for successful tests even when --nopcature for cg_clif

4 participants